Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honor custom separator in ping sse #91

Merged
merged 2 commits into from
Mar 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sse_starlette/sse.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import io
import logging
import re
from datetime import datetime
from datetime import datetime, timezone
from functools import partial
from typing import (
Any,
@@ -316,7 +316,9 @@ async def _ping(self, send: Send) -> None:
if self.ping_message_factory:
assert isinstance(self.ping_message_factory, Callable) # type: ignore # https://github.com/python/mypy/issues/6864
ping = (
ServerSentEvent(comment=f"ping - {datetime.utcnow()}").encode()
ServerSentEvent(
comment=f"ping - {datetime.now(timezone.utc)}", sep=self.sep
).encode()
if self.ping_message_factory is None
else ensure_bytes(self.ping_message_factory(), self.sep)
)