Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslog-format: add support for no-rfc3164-fallback flag #3891

Merged

Conversation

bazsi
Copy link
Collaborator

@bazsi bazsi commented Jan 27, 2022

This flag would allow you to attempt parsing RFC5424 first without
an automatic fallback to RFC3164.

RFC3164. With this option it is possible to use drop-invalid(yes)
plus no-rfc3164-fallback, effectively being able to filter on RFC5424 only.

Signed-off-by: Balazs Scheidler [email protected]

@ryanfaircloth
Copy link
Contributor

This will be very useful

@kira-syslogng
Copy link
Contributor

Build SUCCESS

MrAnno
MrAnno previously approved these changes Jan 27, 2022
Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
(There is a style-format issue in the modified test)

@MrAnno
Copy link
Collaborator

MrAnno commented Jan 27, 2022

Should we add a news entry about this? This might come in handy when writing SCL blocks or format-based filters.

This flag would allow you to attempt parsing RFC5424 first without
an automatic fallback to RFC3164.

RFC3164. With this option it is possible to use drop-invalid(yes)
plus no-rfc3164-fallback, effectively being able to filter on RFC5424 only.

Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi bazsi force-pushed the syslog-format-flag-no-rfc3164-fallback branch from adc4853 to a5d06f3 Compare January 28, 2022 17:16
Signed-off-by: Balazs Scheidler <[email protected]>
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@MrAnno MrAnno added this to the syslog-ng-3.36 milestone Jan 28, 2022
@alltilla alltilla merged commit b3cabeb into syslog-ng:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants