Support hosting WebAssembly demo page locally #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Apr 8, 2024
jserv
requested changes
Apr 8, 2024
|
Run Note that you should install emcc then source your emcc firstly. In macOS or Linux, use |
Done. |
|
README will be updated on future PR. |
jserv
reviewed
Apr 8, 2024
ChinYikMing
force-pushed
the
serve-wasm
branch
4 times, most recently
from
eb750cc to
50e9b74
Compare
jserv
requested changes
Apr 9, 2024
To enhance the user experience of using WebAssembly version of rv32emu, we shall provide a Makefile target (serve-wasm) to serve the WebAssembly demo page in an easy way. Since rv32emu leverages TCO (tail call optimization) when being compiled, so we have to tell if the user's browser supports TCO. Currently, only Chrome with MAJOR 112 and Firefox with MAJOR 121 supports TCO execution runtime, thus we focus on this two browsers. Also, use color text to remind the users if they need to update their Chrome or Firefox. See also: sysprog21#75
mk/external.mk should comes before mk/wasm.mk since mk/wasm.mk depends on targets which defined in mk/external.mk to fetch externals.
Done. |
jserv
reviewed
Apr 9, 2024
jserv
reviewed
Apr 9, 2024
ChinYikMing
force-pushed
the
serve-wasm
branch
3 times, most recently
from
c59edde to
f9e95e3
Compare
|
Thank @ChinYikMing for contributing! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Support hosting WebAssembly demo page locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enhance the user experience of using WebAssembly version of rv32emu, we shall provide a Makefile target (serve-wasm) to serve the WebAssembly demo page in an easy way.
Since rv32emu leverages TCO (tail call optimization) when being compiled, so we have to tell if the user's browser supports TCO. Currently, only Chrome with MAJOR 112 and Firefox with MAJOR 121 supports TCO execution runtime, thus we focus on this two browsers. Also, use color text to remind the users if they need to update their Chrome or Firefox.
See also: #75