Fix insufficient memory on some platforms #449
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Problem]
The MEM_SIZE is hard-corded, but on some platforms, memory is insufficient.
Perhaps we should allow user to config accordingly
[Solution]
Expose an environment variable, CONFIG_MEM_SIZE, to allow user config the memory size with it
[Test]
before $> make
$> ./build/rv32emu ./build/hello.elf
rv32emu: src/riscv.c:199: rv_create: Assertion `attr->mem' failed. Aborted (core dumped)
after $> CONFIG_MEM_SIZE=0x40000000 make
$> ./build/rv32emu ./build/hello.elf
Hello World!
Hello World!
Hello World!
Hello World!
Hello World!
inferior exit code 0
[Reference]
#488