Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bump Ubuntu to 24.04-LTS #497

Merged
merged 1 commit into from
Oct 4, 2024
Merged

CI: Bump Ubuntu to 24.04-LTS #497

merged 1 commit into from
Oct 4, 2024

Conversation

jserv
Copy link
Contributor

@jserv jserv commented Oct 3, 2024

Ubuntu Linux 24.04 (noble) is the latest LTS release, and this commit updates the CI pipeline hosts and recommended development environments accordingly. The version of clang-format is updated to v18, with all C source files re-indented. LLVM is also upgraded to version 18.

@jserv jserv force-pushed the ci-ubuntu-lts branch 3 times, most recently from e15f42a to 04970da Compare October 3, 2024 13:37
@jserv
Copy link
Contributor Author

jserv commented Oct 3, 2024

The performance regression check failed because of the change of RISC-V directory layout. Hence, I have to make the following changes:

--- a/tests/coremark.py
+++ b/tests/coremark.py
@@ -14,7 +14,7 @@ if not file_exist:
     exit(1)
 print("Start Test CoreMark benchmark")
 comp_proc = subprocess.check_output(
-    "build/rv32emu build/coremark.elf {}".format(coremark_param), shell=True).decode("utf-8")
+    "build/rv32emu build/riscv32/coremark {}".format(coremark_param), shell=True).decode("utf-8")
 if not comp_proc or comp_proc.find("Error") != -1:
     print("Test Error")
     exit(1)
diff --git a/tests/dhrystone.sh b/tests/dhrystone.sh
index bc3a03e..6e8650d 100755
--- a/tests/dhrystone.sh
+++ b/tests/dhrystone.sh
@@ -8,7 +8,7 @@ N_RUNS=10
 function run_dhrystone()
 {
     # Run Dhrystone and extract the DMIPS value
-    output=$($RUN $O/dhrystone.elf 2>&1)
+    output=$($RUN $O/riscv32/dhrystone 2>&1)
     local exit_code=$?
     [ $exit_code -ne 0 ] && fail
     dmips=$(echo "$output" | grep -oE '[0-9]+' | awk 'NR==5{print}')

However, both dhrystone and coremark took significantly longer, making continuous benchmarking impractical.
@vacantron, can you check?

@jserv jserv added this to the release-2024.1 milestone Oct 3, 2024
@henrybear327 henrybear327 self-requested a review October 3, 2024 18:09
@jserv
Copy link
Contributor Author

jserv commented Oct 3, 2024

However, both dhrystone and coremark took significantly longer, making continuous benchmarking impractical.

Elapsed time measured on AMD Ryzen Threadripper 2990WX 32-Core Processor: (single iteration)

  • Dhrystone: 4m9.398s
  • CoreMark: 2m25.966s

@jserv jserv force-pushed the ci-ubuntu-lts branch 3 times, most recently from fd3956d to 57a047c Compare October 3, 2024 22:36
Ubuntu Linux 24.04 (noble) is the latest LTS release, and this commit
updates the CI pipeline hosts and recommended development environments
accordingly. The version of clang-format is updated to v18, with all C
source files re-indented. LLVM is also upgraded to version 18.

After the adjustment of benchmark iterations, Dhrystone and CoreMark
take significantly longer, and the aggregation script is limited to
single run.
@jserv jserv merged commit 971e739 into master Oct 4, 2024
15 checks passed
@jserv jserv deleted the ci-ubuntu-lts branch October 4, 2024 13:16
vestata pushed a commit to vestata/rv32emu that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants