Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused structure "chain_entry_t" #515

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

vacantron
Copy link
Collaborator

This structure was out of date and might become buggy in the upcoming system simulation.

src/cache.c Outdated Show resolved Hide resolved
src/emulate.c Outdated Show resolved Hide resolved
src/emulate.c Outdated Show resolved Hide resolved
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Benchmark suite Current: 4b32e32 Previous: 1a12fd6 Ratio
Dhrystone 1542 Average DMIPS over 10 runs 1522 Average DMIPS over 10 runs 0.99
Coremark 1439.724 Average iterations/sec over 10 runs 1403.675 Average iterations/sec over 10 runs 0.97

This comment was automatically generated by workflow using github-action-benchmark.

This structure was out of date and might become buggy in the upcoming
system simulation.

Close sysprog21#513
@vacantron
Copy link
Collaborator Author

@jserv , could you re-run the jobs from the tab of GitHub Actions? It seems like the Internet issue that causes make artifact failed.

@jserv jserv merged commit ce548ff into sysprog21:master Nov 24, 2024
8 checks passed
@jserv
Copy link
Contributor

jserv commented Nov 24, 2024

Thank @vacantron for contributing!

vestata pushed a commit to vestata/rv32emu that referenced this pull request Jan 24, 2025
Drop unused structure "chain_entry_t"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants