Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make emu_update_uart_interrupts function static #540

Closed
wants to merge 1 commit into from

Conversation

otteryc
Copy link
Contributor

@otteryc otteryc commented Jan 23, 2025

emu_update_uart_interrupts is internally used in src/system.c, restrict its visibility to improve encapsulation.

emu_update_uart_interrupts is internally used in src/system.c, restrict
its visibility to improve encapsulation.
@jserv
Copy link
Contributor

jserv commented Jan 23, 2025

Symbol emu_update_uart_interrupts is used in src/emulate.c. Unless you can introduce another indirection, keep it simple, stupid.

@otteryc
Copy link
Contributor Author

otteryc commented Jan 23, 2025

Oops, I omitted it, sorry for confusion.

@otteryc otteryc closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants