Implement Queues Consumer #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check this PR in this week, I'm sorry for being late. |
|
I'm sorry for being late. LGTM, thanks! |
syumai
approved these changes
Jan 15, 2025
syumai
reviewed
Jan 15, 2025
Comment on lines
+84
to
+98
| func (m *ConsumerMessage) IntBody() (int, error) { | ||
| if m.Body.Type() == js.TypeNumber { | ||
| return m.Body.Int(), nil | ||
| } | ||
|
|
||
| return 0, fmt.Errorf("message body is not a number: %v", m.Body) | ||
| } | ||
|
|
||
| func (m *ConsumerMessage) FloatBody() (float64, error) { | ||
| if m.Body.Type() == js.TypeNumber { | ||
| return m.Body.Float(), nil | ||
| } | ||
|
|
||
| return 0, fmt.Errorf("message body is not a number: %v", m.Body) | ||
| } |
There was a problem hiding this comment.
These methods seem to be just wrappers around js.Value.
Since we can also use Body directly, I'll omit these methods and leave only StringBody and BytesBody. (StringBody is also just a wrapper, but I'll keep it because I think it will be used often.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds support for Queues consumer.
Motivation
#53