Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/torchmetrics upgrade #10

Merged
merged 3 commits into from
Nov 19, 2023
Merged

Feature/torchmetrics upgrade #10

merged 3 commits into from
Nov 19, 2023

Conversation

szmazurek
Copy link
Owner

Fixes #ISSUE_NUMBER

Proposed Changes

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@szmazurek
Modified classification metrics
faa2a06
@szmazurek
Upgrade to torchmetrics 1.1.2
97c395c 
- added requirements in setup.py
- modified the metrics constructors in the GANDLF.metrics.generic and .classification
files to be compatibile with updated torchmetrics API
- modified .yaml file to cover new fields compatibile with new torchmetrics API
- defined utility functions for easier construction of metrics from new torchmetrics API
@szmazurek
Hotfix for test_full.py script
baf5153
@szmazurek szmazurek merged commit 1c962d7 into master Nov 19, 2023
9 of 11 checks passed
@szmazurek szmazurek deleted the feature/torchmetrics_upgrade branch November 21, 2023 07:43
szmazurek pushed a commit that referenced this pull request Nov 5, 2024
@benmalef
Add logging documentation (#10)
7d6f25e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@szmazurek