Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/torchmetrics upgrade #12

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Conversation

szmazurek
Copy link
Owner

Fixes #ISSUE_NUMBER

Proposed Changes

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

szmazurek and others added 5 commits November 21, 2023 09:03
- removed redundant if-else statement
- fixed bug with incorrect reading from the average_types_keys dictionary
- moved utility functions into utils.generic.py
- simplified the creation of generic metrics
- modified the usage docs to link to the current torchmetrics version docs
@szmazurek szmazurek merged commit 1b2ee5a into master Nov 22, 2023
9 of 11 checks passed
@szmazurek szmazurek deleted the feature/torchmetrics_upgrade branch November 22, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant