Bridged device basic information #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0bst4r
requested changes
Jan 6, 2025
packages/backend/src/matter/behaviors/basic-information-server.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/matter/behaviors/basic-information-server.ts
Outdated
Show resolved
Hide resolved
This will allow us to retrieve information about the device of an entity later, such as product names and versions. This could also be useful for automatic grouping of entities.
We may have product information available in the device registry - use it where possible instead of hardcoded or hashed values.
kennylevinsen
force-pushed
the
bridged-device-basic-information
branch
from
0216df5 to
4c7153d
Compare
|
I have undone the changes to vendorName and serialNumber for now, and instead added comments as to why they're "sensitive". Then maybe we can revisit them later. |
t0bst4r
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumb through the actual bridged device details. Google Home only seems to pick up the product name, but "Technical Information" seems to always give the bridge details which is a bit borked but just seems like a Google Home bug - the matter.js shell shows the details correctly. Google Home also does not seem to reload the details after a device has been added.
Z2M seems to not fill out the extended details properly (model_id for example), and so tends to create rather long strings which are cut to length with "..." at the end. These should be improved on the Z2M side. EDIT: Koenkk/zigbee2mqtt#25389Merged