fix(buffer): emit last buffer if source completes

t1bb4r · Aug 3, 2018 · ed3c82d · ed3c82d
1 parent 4110711
commit ed3c82d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/spec/operators/buffer-spec.ts b/spec/operators/buffer-spec.ts
@@ -221,4 +221,16 @@ describe('Observable.prototype.buffer', () => {
     expectObservable(a.pipe(buffer(b), take(1))).toBe(expected, expectedValues);
     expectSubscriptions(b.subscriptions).toBe(bsubs);
   });
+
+  it('should emit last buffer if source completes', () => {
+    const a =    hot('-a-b-c-d-e-f-g-h-i-|');
+    const b =    hot('-----B-----B--------');
+    const expected = '-----x-----y-------(z|)';
+    const expectedValues = {
+      x: ['a', 'b', 'c'],
+      y: ['d', 'e', 'f'],
+      z: ['g', 'h', 'i']
+    };
+    expectObservable(a.pipe(buffer(b))).toBe(expected, expectedValues);
+  });
 });
diff --git a/src/internal/operators/buffer.ts b/src/internal/operators/buffer.ts
@@ -76,6 +76,14 @@ class BufferSubscriber<T> extends OuterSubscriber<T, any> {
     this.buffer.push(value);
   }
 
+  protected _complete() {
+    const buffer = this.buffer;
+    if (buffer.length > 0) {
+      this.destination.next(buffer);
+    }
+    super._complete();
+  }
+
   notifyNext(outerValue: T, innerValue: any,
              outerIndex: number, innerIndex: number,
              innerSub: InnerSubscriber<T, any>): void {