Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a fourth param to thumbnailer to prevent gifs -> png? #28

Closed
turt2live opened this issue Jan 11, 2018 · 2 comments
Closed

Support a fourth param to thumbnailer to prevent gifs -> png? #28

turt2live opened this issue Jan 11, 2018 · 2 comments
Labels
enhancement no matrix spec
Milestone
v1.0.0

Comments

@turt2live
Copy link
Member

As per notes in element-hq/element-web#5922 (comment) - nothing is really set in stone there, it's just an idea at this point.
@turt2live turt2live added this to the v1.0.0 milestone Jan 11, 2018
turt2live added a commit that referenced this issue Jan 12, 2018
@turt2live
Support ?animate=true/false on thumbnail generation
9bb3aa3 
This is the first part of #28. It defaults to false to maintain synapse parity and normal expected behaviour. This commit does the basic gif->png thumbnailing (forced when required), but does not handle resizing gifs.
turt2live added a commit that referenced this issue Jan 12, 2018
@turt2live
First attempt at generating animated thumbnails
c0cdb77 
This doesn't work on two grounds:
* There is significant pixelation
* The resulting image size is wrong (but the frames are correct)

This is part of #28 and needs some cleaning up before it's an active code path. Pushing now because this code path won't be activated under normal circumstances.
@turt2live
Copy link
Member Author

Synapse issues:

turt2live added a commit that referenced this issue Jan 16, 2018
@turt2live
Fix animated thumbnailer
d744182 
* Use a swap image for resizing the frame (otherwise the frame gets corrupted)
* Use a linear resample filter (better output quality)
* Redraw the frame using a different technique
* Set the bounds of the image on the image config prior to re-encoding (otherwise the image has a bunch of whitespace)

This finishes #28
@turt2live
Copy link
Member Author

The animated parameter is now a thing, although Riot doesn't use it at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement no matrix spec
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@turt2live