Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singleflight crash #451

Closed
Tracked by #415
turt2live opened this issue Aug 22, 2023 · 2 comments
Closed
Tracked by #415

singleflight crash #451

turt2live opened this issue Aug 22, 2023 · 2 comments
Labels
bug crash release-blocker

Comments

@turt2live
Copy link
Member 

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x4d2ca9]

goroutine 141610 [running]:
io.(*nopCloser).Read(0x48?, {0xc0004c4000?, 0xc00051ae60?, 0x7fbe80b0e4e0?})
        <autogenerated>:1 +0x29
io.copyBuffer({0x13bed20, 0xc00051ae60}, {0x7fbe80b47738, 0xc000552550}, {0x0, 0x0, 0x0})
        /usr/local/go/src/io/io.go:427 +0x1b2
io.Copy(...)
        /usr/local/go/src/io/io.go:386
github.com/t2bot/go-singleflight-streams.finishCopy({0xc0005b60e8?, 0x1?, 0x1?}, {0x13c5a58?, 0xc000552550?})
        /go/pkg/mod/github.com/t2bot/[email protected]/sfstreams.go:132 +0x194
created by github.com/t2bot/go-singleflight-streams.(*Group).doWork.func1
        /go/pkg/mod/github.com/t2bot/[email protected]/sfstreams.go:116 +0x5cc
@turt2live turt2live mentioned this issue Aug 22, 2023
Closed
73 tasks
turt2live added a commit to t2bot/go-singleflight-streams that referenced this issue Aug 25, 2023
@turt2live
Flip boolean logic & check for zero value as well
3269fb2 
For t2bot/matrix-media-repo#451
turt2live added a commit that referenced this issue Aug 25, 2023
@turt2live
Update singleflight streams
8e123fa 
For #451
@turt2live
Copy link
Member Author

this is still happening

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x4c1389]

goroutine 4864653 [running]:
io.(*nopCloser).Read(0x48?, {0xc000fce000?, 0xc002881a90?, 0x7f69d4c19ea8?})
        <autogenerated>:1 +0x29
io.copyBuffer({0x135c560, 0xc002881a90}, {0x7f69d4d919a0, 0xc003428d10}, {0x0, 0x0, 0x0})
        /usr/local/go/src/io/io.go:427 +0x1b2
io.Copy(...)
        /usr/local/go/src/io/io.go:386
github.com/t2bot/go-singleflight-streams.finishCopy({0xc001336568?, 0x1?, 0x1?}, {0x1363220?, 0xc003428d10?})
        /go/pkg/mod/github.com/t2bot/[email protected]/sfstreams.go:133 +0x194
created by github.com/t2bot/go-singleflight-streams.(*Group).doWork.func1
        /go/pkg/mod/github.com/t2bot/[email protected]/sfstreams.go:117 +0x61e

@turt2live turt2live reopened this Sep 5, 2023
@turt2live
Copy link
Member Author

Fixed by code for #457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug crash release-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live