Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create a new object for the session callback #1330

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Apr 3, 2023

Ref: nextauthjs/next-auth#7132 (comment)

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

💯

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

🦋 Changeset detected

Latest commit: 46f9d58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 7:51pm

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Running Lighthouse audit...

@c-ehrlich
Copy link
Member

do we still need this now that 4.21.1 is out?

@juliusmarminge
Copy link
Member Author

do we still need this now that 4.21.1 is out?

As mentioned by Balazs, the type is texhnically incorrect now and it is in fact DefaultSession thats passed to this callback

Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually tested with next-auth 4.21.0

@c-ehrlich c-ehrlich added this pull request to the merge queue Apr 5, 2023
Merged via the queue into next with commit 85997e0 Apr 5, 2023
@c-ehrlich c-ehrlich deleted the fix-session-type branch April 5, 2023 22:31
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
* spread new object

* whoops

* Create .changeset/itchy-cooks-sell.md

---------

Co-authored-by: Christopher Ehrlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants