handles case when publication exists #32
Merged
+47
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Calza <[email protected]>
brunocalza
changed the title
brunocalza
commented
Mar 26, 2024
| @@ -43,7 +43,13 @@ impl EVMClient for BasinClient { | |||
| .create_pub(owner, name.into()) | |||
| .send() | |||
| .await | |||
| .map_err(|e| Error::Evm(e.to_string()))?; | |||
| .map_err(|e| { | |||
| if e.is_revert() { | |||
There was a problem hiding this comment.
I've tried to use e.decode_contract_revert() to decode the error and check the revert message, but could not get it to work. So I've settled on just checking if it's a revert. Not ideal, but good enough for now.
There was a problem hiding this comment.
e.decode_contract_revert() did it return None?
There was a problem hiding this comment.
e.decode_contract_revert()did it returnNone?
yeah! not sure why
avichalp
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check in case a vault already exists. This was something @dtbuchholz asked.