Router refresh fix + tRPC improvement #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
asutula
commented
Aug 12, 2024
Comment on lines
25
to
+26
| router.push(`/${org.slug}/${project.slug}`); | ||
| router.refresh(); |
There was a problem hiding this comment.
Here's an example of how the router refresh needs to happen after the navigation.
Comment on lines
+32
to
+34
| void utils.deployments.deploymentsByEnvironmentId.invalidate({ | ||
| environmentId: env.id, | ||
| }); |
There was a problem hiding this comment.
Here's an example of using this tRPC utils feature that lets you imperatively invalidate a query, resulting in any users of that query to refetch their data. This imperative style is cleaner or easier to use in many cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a whole class of bugs where, after making a data mutation on the server side, you don't see data update on the client. It turns out that if you refresh the router, it needs to happen after any navigation, or else the router refresh gets cancelled.
This also uses a feature of tRPC I previously didn't know about that makes refreshing data on the client side cleaner.