Improve performance when using SAF #1
Conversation
|
See also #2, which improves performance further by - as opposed to optimizing the documents traversal - avoiding it entirely. |
| @@ -210,8 +210,7 @@ public UniFile[] listFiles(FilenameFilter filter) { | |||
| final NamedUri[] uris = DocumentsContractApi21.listFilesNamed(mContext, mUri); | |||
| final ArrayList<UniFile> results = new ArrayList<>(); | |||
| for (NamedUri uri : uris) { | |||
| String name = DocumentsContractApi19.getName(mContext, uri.uri); | |||
| if (name != null && filter.accept(this, name)) { | |||
| if (name != null && filter.accept(this, uri.name)) { | |||
There was a problem hiding this comment.
Should it be this? Or should we still have the getName above? I tried checking out the branch locally and it failed to compile because name isn't declared.
| if (name != null && filter.accept(this, uri.name)) { | |
| if (uri.name != null && filter.accept(this, uri.name)) { |
There was a problem hiding this comment.
Oops! Yes, it should be uri.name.
Anyway, Imma close this in favor of #2, those optimization can be implemented there.
There was a problem hiding this comment.
Ok cool, I will do my best to merge in your changes to that branch.
There was a problem hiding this comment.
Oop, nevermind, since #2 got merged before I went back and updated things, it might make sense to re-open this PR so it can be merged separately.
No description provided.