Name some of the longer-lived lifetimes #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
force-pushed
the
named-lifetimes
branch
from
f4d32dd to
305d851
Compare
stevenroose
force-pushed
the
named-lifetimes
branch
2 times, most recently
from
5c18b3e to
d2f7962
Compare
Lifetime names like 'a are usually more suitable for "anonymous" lifetimes that have a limited scope. Lifetimes defined on types and implementations can sometimes be more significant and it's usual to name those with multi-character lifetime names. I chose the following names: - 'bf: whenever there is some underlying (usually ephemeral) buffer This includes all the events and the ephemeral buffer in buffered readers. - 'inp: the underlying input bytes for a borrowing reader, Note that for events, the 'bf refers to this buffer too in the case of these readers. - In the BufferedInput trait, I used 'bf for slices it outputs from the buffer and 'int for the lifetime of the internal type, which is equal to 'inp for borrowing readers and the type lifetime of the BufRead for buffered readers (usually 'static).
|
Some progress has been made on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #330. Closes #331.
Lifetime names like 'a are usually more suitable for "anonymous"
lifetimes that have a limited scope. Lifetimes defined on types and
implementations can sometimes be more significant and it's usual to name
those with multi-character lifetime names.
I chose the following names:
'bf: whenever there is some underlying (usually ephemeral) bufferThis includes all the events and the ephemeral buffer in buffered
readers.
'inp: the underlying input bytes for a borrowing reader,Note that for events, the
'bfrefers to this buffer too in the case ofthese readers.
BufferedInputtrait, I used'bffor slices it outputs from thebuffer and
'intfor the lifetime of the internal type, which is equalto '
inpfor borrowing readers and the type lifetime of theBufReadforbuffered readers (usually
'static).