Fix --mutually-exclusive-features containing optional deps.
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have a follow-up PR after this gets merged, so publishing can wait. 👍 |
taiki-e
added
the
A-features
|
Published in 0.6.34. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--mutually-exclusive-featurescontains an implicit feature derived from an optional dependency (e.g.tokio), then the activation of that feature was not correctly detected in the case offeat = ["tokio/full"].This PR addresses that and such activations are now detected in
matches_recursive.Somewhat similar are cases of
feat = ["tokio?/full"], however those continue to not be detected because they don't actually activate the feature. They propagate the sub-feature only if the main feature has already been activated.