Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for uplift of drop-bounds lint #272

Closed
taiki-e opened this issue Sep 10, 2020 · 3 comments
Closed

Prepare for uplift of drop-bounds lint #272

taiki-e opened this issue Sep 10, 2020 · 3 comments
Assignees
@taiki-e
Labels
C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream)

Comments

@taiki-e
Copy link
Owner

taiki-e commented Sep 10, 2020

rust-lang/rust#75699 uplifts clippy's drop_bounds lint to rustc.
If the implementation is the same as clippy, the code generated by the macro will also be warned (this behavior is probably correct for this lint), and pin-project(-lite) users will be affected by this.

Once rust-lang/rust#75699 or rust-lang/compiler-team#347 merged (or approved), it would be nice to be able to create a release including a patch that allows this lint.
This was referenced Sep 17, 2020
Merged
Merged
@taiki-e
Copy link
Owner Author

taiki-e commented Sep 17, 2020

I'll merge this and publish new releases of pin-project and pin-project-lite, when FCP of rust-lang/compiler-team#347 is finished.

FYI @notriddle

@taiki-e taiki-e mentioned this issue Sep 17, 2020
Merged
@taiki-e taiki-e self-assigned this Sep 17, 2020
bors bot added a commit that referenced this issue Sep 22, 2020
@bors @taiki-e
Merge #273
7d40769 
273: Prepare for uplift of drop-bounds lint r=taiki-e a=taiki-e

cc #272 

Co-authored-by: Taiki Endo <[email protected]>
bors bot added a commit to taiki-e/pin-project-lite that referenced this issue Oct 1, 2020
@bors @taiki-e
Merge #27
506c864 
27: Prepare for uplift of drop-bounds lint r=taiki-e a=taiki-e

cc taiki-e/pin-project#272 

Co-authored-by: Taiki Endo <[email protected]>
bors bot added a commit that referenced this issue Oct 1, 2020
@bors @taiki-e
Merge #274
7f92561 
274: v0.4: Prepare for uplift of drop-bounds lint r=taiki-e a=taiki-e

This is the backport of #273 

cc #272 

Co-authored-by: Taiki Endo <[email protected]>
@taiki-e
Copy link
Owner Author

taiki-e commented Oct 1, 2020

Done in pin-project 0.4.25 and pin-project-lite 0.1.10.

@taiki-e taiki-e closed this as completed Oct 1, 2020
@taiki-e taiki-e added the C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream) label Oct 4, 2020
@taiki-e
Copy link
Owner Author

taiki-e commented Oct 5, 2020

If the implementation is the same as clippy

The code generated by the external macro doesn't actually seem to get a warning (probably because LintContext::struct_span_lint is used). So this probably wasn't really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taiki-e taiki-e

Labels
C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taiki-e