Implement !Unpin option #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
no-unpin
branch
6 times, most recently
from
9ec67a4 to
2706e39
Compare
taiki-e
force-pushed
the
no-unpin
branch
5 times, most recently
from
637a13d to
bdcfbf8
Compare
taiki-e
added
C-enhancement
unrestricted_attribute_tokens requires 1.34
taiki-e
commented
May 9, 2020
There was a problem hiding this comment.
It's been more than a year since 1.34 was released, and most of the users of this crate depend on futures_api that requires 1.36 (and many of them depend on async_await that requires 1.39). so bumping MSRV to 1.34 is probably no problem.
(Also, the old receiver lifetime elision rule is not convenient, so I guess very few people really want to use pin in those versions...)
bors r+
|
Build succeeded: |
4 tasks
I think we need to decide on a policy when we release 1.0, but for now, I would like to support a year ago rustc (as long as it is possible). |
bors bot
added a commit
that referenced
this pull request
May 18, 2020
202: Allow naming the projected types r=taiki-e a=taiki-e
By passing an argument with the same name as the method to the attribute, you can name the projection type returned from the method:
```rust
#[pin_project(
Replace,
project = StructProj,
project_ref = StructProjRef,
project_replace = StructProjOwn,
)]
struct Struct<T> {
#[pin]
field: T,
}
let mut x = Struct { field: 0 };
let StructProj { field } = Pin::new(&mut x).project();
let StructProjRef { field } = Pin::new(&x).project_ref();
let StructProjOwn { field } = Pin::new(&mut x).project_replace(Struct { field: 1 });
```
cc #43
Closes #124
TODO:
* [x] add tests
* [x] write docs
* [x] separate unrelated changes; done in #214
* [x] msrv (`unrestricted_attribute_tokens` requires 1.34); done in #219
Co-authored-by: Taiki Endo <[email protected]>
This was referenced Oct 5, 2020
Merged
bors bot
added a commit
that referenced
this pull request
Oct 5, 2020
292: Bump MSRV to 1.37 r=taiki-e a=taiki-e Bumps MSRV to 1.37 because `underscore_const_names` requires 1.37. This allows removing the build script. It's been more than a year since [1.37 was released](https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html), and most of the users of this crate depend on `futures_api` that requires 1.36 and `async_await` that requires 1.39. so bumping MSRV to 1.37 is probably no problem. Also, given that pin-project-lite's MSRV is 1.37 and the possibility of switching, most futures-related utilities require at least 1.37. cc #264 Refs: #219 Co-authored-by: Taiki Endo <[email protected]>
taiki-e
removed
the
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
Also, bump MSRV to 1.34 because
unrestricted_attribute_tokensrequires 1.34 (#202 also requires 1.34).Closes #108