Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot strip ARM binaries #8

Closed
Shadow53 opened this issue Sep 27, 2021 · 3 comments · Fixed by #9
Closed

Cannot strip ARM binaries #8

Shadow53 opened this issue Sep 27, 2021 · 3 comments · Fixed by #9
Labels
bug Something isn't working

Comments

@Shadow53
Copy link

I am using this action to cross-compile a CLI application (called hoard) for multiple platforms. When compiling for the armv7-linux-androideabi target, I got the following error:

strip: Unable to recognise the format of the input file `hoard'

I am not sure if there is a way to strip these binaries or if stripping should be skipped for them, but either solution would be nice so I can distribute downloads for Android platforms.

@Shadow53 Shadow53 changed the title Strip Android Binaries Cannot strip ARM binaries Sep 27, 2021
@Shadow53
Copy link
Author

Update: Just got this with the aarch64-unknown-linux-gnu target, so I'm thinking this may be for ARM or even foreign architectures in general.

@taiki-e
Copy link
Owner

taiki-e commented Sep 27, 2021

Thanks for the report!

We probably need to skip strip if a target with a different architecture than the host is specified.

Or, I think it is possible to make the strip work on those architectures, but it requires additional dependencies (e.g., on arm-linux-gnueabihf-strip via gcc-arm-linux-gnueabihf, aarch64-linux-gnu-strip via gcc-aarch64-linux-gnu).
So it might be better to use them when they are available and warn when they are not.

@taiki-e taiki-e added the bug Something isn't working label Sep 27, 2021
@taiki-e
Copy link
Owner

taiki-e commented Sep 29, 2021

Fixed in v1.1.0.

taiki-e referenced this issue in nextest-rs/nextest Mar 28, 2024
Restore behavior changed in 4e259a7, because
it turns out that `strip = "debuginfo"` still strips too much.

This was observed with the cargo-nextest 0.9.68-rc.1 binary on illumos, where
`pstack` showed lots of ??? marks.

Part of #1345.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants