-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix strip on non-x86 targets #9
Conversation
This looks like it would do the job! Thanks for being so quick about this. A question, out of curiosity: why run |
I am trying this branch in my CI to test, and I am still getting the same error:
This is with the following Rust toolchains:
Notably, the following successfully built:
It looks like the successful ones were not stripped, as I will update with another comment if I figure anything else out. |
main.sh
Outdated
strip="arm-none-eabi-strip" | ||
fi | ||
;; | ||
aarch64*-unknown-linux-*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Android aarch64 target does not contain -unknown
Okay, I think I found the issue, You set |
Thanks @Shadow53! I've applied both fixes. |
a0c315f
to
4b31686
Compare
I tried to choose the one that worked most reliably because their subtle differences in behavior are complicated (koalaman/shellcheck#1162), but in fact |
I've tested that these work (https://github.com/taiki-e/test/actions/runs/1286975387). merging |
There are dedicated stripping tools for architectures other than x86. If they are installed, use them; otherwise, skip strip.
Fixes #8
cc @Shadow53