Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix isSignalSent bug #15970

Merged
merged 7 commits into from
Feb 21, 2024
Merged

fix(protocol): fix isSignalSent bug #15970

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
106fab6
Update SignalService.sol
dantaik Feb 21, 2024
dc29551
Update SignalService.sol
dantaik Feb 21, 2024
b109776
Update SignalService.sol
dantaik Feb 21, 2024
84c1edd
Update SignalService.sol
dantaik Feb 21, 2024
b5b6d66
Update SignalService.sol
dantaik Feb 21, 2024
7f2363d
Update SignalService.sol
dantaik Feb 21, 2024
9573729
Merge branch 'main' into signal_value_1
dantaik Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/protocol/contracts/signal/SignalService.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ contract SignalService is EssentialContract, ISignalService {
mapping(address => bool) public isAuthorized; // slot 2
uint256[48] private __gap;

event SignalSent(address app, bytes32 signal, bytes32 slot, bytes32 value);
event Authorized(address indexed addr, bool authrized);

error SS_EMPTY_PROOF();
Expand Down Expand Up @@ -172,7 +173,7 @@ contract SignalService is EssentialContract, ISignalService {

/// @inheritdoc ISignalService
function isSignalSent(address app, bytes32 signal) public view returns (bool) {
return _loadSignalValue(app, signal) == signal;
return _loadSignalValue(app, signal) != 0;
}

/// @inheritdoc ISignalService
Expand Down Expand Up @@ -281,6 +282,7 @@ contract SignalService is EssentialContract, ISignalService {
assembly {
sstore(slot, value)
}
emit SignalSent(app, signal, slot, value);
}

function _cacheChainData(
Expand Down
Loading