Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): make TaikoL2Deprecated ABI go-ethereum compatible #18659

Merged
merged 6 commits into from
Dec 27, 2024
Merged

feat(protocol): make TaikoL2Deprecated ABI go-ethereum compatible #18659

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
45bca57
feat(protocol): make `TaikoL2Deprecated` ABI go-ethereum compatible
davidtaikocha Dec 27, 2024
74d6dcd
fix lint
dantaik Dec 27, 2024
fc96bc8
fix
dantaik Dec 27, 2024
bcde7ac
fmt
dantaik Dec 27, 2024
397cf16
fix test
YoGhurt111 Dec 27, 2024
69aa570
fix test
YoGhurt111 Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions packages/protocol/contracts/layer2/based/TaikoL2Deprecated.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,45 +16,45 @@ abstract contract TaikoL2Deprecated {
}

function anchor(
bytes32, /*_l1BlockHash*/
bytes32, /*_l1StateRoot*/
uint64, /*_l1BlockId*/
uint32 /*_parentGasUsed */
bytes32 _l1BlockHash,
bytes32 _l1StateRoot,
uint64 _l1BlockId,
uint32 _parentGasUsed
)
external
deprecated
{ }

function getBasefee(
uint64, /*_anchorBlockId*/
uint32 /*_parentGasUsed*/
uint64 _anchorBlockId,
uint32 _parentGasUsed
)
public
pure
deprecated
returns (uint256, /*basefee_*/ uint64 /*parentGasExcess_*/ )
returns (uint256 basefee_, uint64 parentGasExcess_)
{ }

function adjustExcess(
uint64, /*_currGasExcess*/
uint64, /*_currGasTarget*/
uint64 /*_newGasTarget*/
uint64 _currGasExcess,
uint64 _currGasTarget,
uint64 _newGasTarget
)
public
pure
deprecated
returns (uint64 /*newGasExcess_*/ )
returns (uint64 newGasExcess_)
{ }

function calculateBaseFee(
LibSharedData.BaseFeeConfig calldata, /*_baseFeeConfig*/
uint64, /*_blocktime*/
uint64, /*_parentGasExcess*/
uint32 /*_parentGasUsed*/
LibSharedData.BaseFeeConfig calldata _baseFeeConfig,
uint64 _blocktime,
uint64 _parentGasExcess,
uint32 _parentGasUsed
)
public
pure
deprecated
returns (uint256, /*basefee_*/ uint64 /*parentGasExcess_*/ )
returns (uint256 basefee_, uint64 parentGasExcess_)
{ }
}