Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): rename resolve() to resolveAddress() #18835

Merged
merged 4 commits into from
Jan 24, 2025
Merged

fix(protocol): rename resolve() to resolveAddress() #18835

merged 4 commits into from
Jan 24, 2025

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jan 24, 2025 •
edited
Loading

The renaming is to make sure ForkRouter can work based on different function selectors for Ontake and Pacaya.

@dantaik dantaik marked this pull request as ready for review January 24, 2025 15:04
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jan 24, 2025 •
edited
Loading

fix(protocol): rename resolve() to resolveAddress()

Generated at commit: d9b1ad558f7311ae2398f866ac11d8e0bb84dbed

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
3
0
10
40
56
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik merged commit 93f4272 into pacaya_fork Jan 24, 2025
6 checks passed
@dantaik dantaik deleted the resolver_name branch January 24, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@YoGhurt111 YoGhurt111 Awaiting requested review from YoGhurt111

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantaik @davidtaikocha