Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复 PivotRoot Invalid arguments 错误 #4

Merged
merged 9 commits into from
Sep 7, 2019
Merged

修复 PivotRoot Invalid arguments 错误 #4

merged 9 commits into from
Sep 7, 2019

Conversation

taikulawo
Copy link
Owner

No description provided.

xianlubird/mydocker#41 (comment)

```
// systemd 加入linux之后, mount namespace 就变成 shared by default, 所以你必须显示
	//声明你要这个新的mount namespace独立。
	syscall.Mount("", "/", "", syscall.MS_PRIVATE | syscall.MS_REC, "")

	defualtMountFlags := syscall.MS_NOEXEC | syscall.MS_NOSUID | syscall.MS_NODEV
	syscall.Mount("proc", "/proc", "proc", uintptr(defualtMountFlags), "")
```

开个分支测试,如果失败,那么虚拟机回滚
.
这是一个Rebase合并

全部的合并分别进行了测试,最后修复了

#3

但 wwcdocker run -ti busybox sh 运行之后并不会获得 sh

进程直接会结束,需要在后续的commit中修复
@taikulawo taikulawo merged commit 0da7a9c into dev Sep 7, 2019
@taikulawo taikulawo deleted the MS_PRIVATE branch September 7, 2019 13:17
taikulawo added a commit that referenced this pull request Sep 7, 2019
* 来自
`https://github.com/xianlubird/mydocker/issues/41#issuecomment-478799767`

```
// systemd 加入linux之后, mount namespace 就变成 shared by default, 所以你必须显示
	//声明你要这个新的mount namespace独立。
	syscall.Mount("", "/", "", syscall.MS_PRIVATE | syscall.MS_REC, "")

	defualtMountFlags := syscall.MS_NOEXEC | syscall.MS_NOSUID | syscall.MS_NODEV
	syscall.Mount("proc", "/proc", "proc", uintptr(defualtMountFlags), "")
```

开个分支测试,如果失败,那么虚拟机回滚

这是一个Rebase合并

全部的合并分别进行了测试,最后修复了

#3

但 wwcdocker run -ti busybox sh 运行之后并不会获得 sh

进程直接会结束,需要在后续的commit中修复
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant