Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #64: Add support for HTTPS query type (type 65) #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

capveg-netdebug
Copy link

@capveg-netdebug capveg-netdebug commented Sep 22, 2023

Fixes #64: Add support for HTTPS query type (type 65)

Summary:

I was getting 'query type 65 is invalid' errors parsing DNS packets
on my machine and this fixes it.

Test Plan:

Added a unit test that parses a wild packet... it works

@capveg-netdebug capveg-netdebug changed the title Fixes #64: Add support for HTTPS query type (type 65) Fixes #46: Add support for HTTPS query type (type 65) Sep 22, 2023
Summary:

I was getting 'query type 65 is invalid' errors parsing DNS packets
on my machine and this fixes it.

Test Plan:

Added a unit test that parses a wild packet... it works <shrug>
@capveg-netdebug capveg-netdebug changed the title Fixes #46: Add support for HTTPS query type (type 65) Fixes #64: Add support for HTTPS query type (type 65) Sep 22, 2023
@tsepanx
Copy link

tsepanx commented Nov 5, 2023

Agree, getting error when trying to parse packet from wireshark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants