Allow multiple topics for notification handlers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill-kerr
requested review from
SeriousBug,
loganhuskins,
AnYoung627,
s-fletcher,
mckbas,
nturnage and
tailwind-dave
SeriousBug
approved these changes
Sep 25, 2023
extract/extract-handlers.ts
Outdated
| return pascalCase( | ||
| `${handler.definition.topicName}-${handler.definition.name}`, | ||
| ); | ||
| return pascalCase(`Notification ${handler.definition.name}`); |
There was a problem hiding this comment.
Could you leave a backwards-compatibility option here so handlers with topicName continue to get the same name?
There was a problem hiding this comment.
Ahh good call, yes can do
loganhuskins
approved these changes
Sep 26, 2023
AnYoung627
approved these changes
Sep 26, 2023
|
@bill-kerr what's going on with this? I just got a notification for it. Was it that you added the beta tag on due to my questions about Draper from the other day? |
I pushed up the package version change since you couldn't find it in code anywhere |
mckbas
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for notification handlers to subscribe to multiple topics.