Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement not-* variant with @media, @supports and @container variants #13995

Closed
wants to merge 3 commits into from

Conversation

RobinMalfait
Copy link
Member

The not-* variant worked with other variants that only included selectors, however some variants where only @media, @supports, and @container is used, the not-* variant would not work.

This PR solves that by inverting the query using the not keyword.

This allows us to use not-print:flex which compiles to:

@media not print {
  .not-print\:flex {
    display: flex;
  }
}

Copy link

@sanbei101 sanbei101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing wrong with that!

Base automatically changed from feat/custom-variants to next July 16, 2024 20:23
@thecrypticace thecrypticace force-pushed the feat/not-with-media-queries branch 2 times, most recently from 5f3eced to b1f3ff3 Compare July 16, 2024 21:37
@thecrypticace thecrypticace force-pushed the feat/not-with-media-queries branch from b1f3ff3 to 261cae5 Compare July 16, 2024 21:42
@RobinMalfait
Copy link
Member Author

Closed in favor of: #14743

@RobinMalfait RobinMalfait deleted the feat/not-with-media-queries branch November 6, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants