Ensure upgrade tool has access to a JS config #14597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
requested review from
RobinMalfait,
thecrypticace and
adamwathan
philipp-spiess
force-pushed
the
feat/upgrade-tool-auto-config
branch
from
b94aefe to
51ef4e6
Compare
RobinMalfait
reviewed
Oct 4, 2024
Comment on lines
-30
to
-34
| // Migrate the important modifier to the end of the utility | ||
| if (utility[0] === '!') { | ||
| utility = `${utility.slice(1)}!` | ||
| } | ||
|
|
There was a problem hiding this comment.
Was this on purpose or was this a leftover from another PR? Seems unrelated to this PR at first but just checking.
There was a problem hiding this comment.
Was on purpose, we don't need to move the important modified at the end inside this loop anymore, now that we always have a config and always run the candidate migrations => The candidate migration will take care of this.
philipp-spiess
force-pushed
the
feat/upgrade-tool-auto-config
branch
from
0ad61df to
c012f15
Compare
RobinMalfait
approved these changes
Oct 7, 2024
Co-authored-by: Robin Malfait <[email protected]>
|
@RobinMalfait haha whoops 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to properly migrate your Tailwind CSS v3 project to v4, we need access to the JavaScript configuration object. This was previously only required for template migrations, but in this PR we're making it so that this is also a prerequisite of the CSS migrations. This is because some migrations, like
@apply, also need to convert candidates that to the v4 syntax and we need the full config in order to properly validate them.In addition to requiring a JS config, we also now attempt to automatically find the right configuration file inside the current working directory. This is now matching the behavior of the Tailwind CSS v3 CLI where it will find the config automatically if it's in the current directory and called
tailwind.conf.js.