Remove theme(inline) option from CSS API
#14894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will only remove it from the CSS API, but we will keep it internally.
These tests ensured that `theme(inline)` worked, either on its own or in combination with other `theme(…)` options. Since `inline` is being removed, we can get rid of these tests as well.
In this case, we already generated the `var(--default-…)` even with `@theme inline` because we just deleted the `inline` option. This updates the input CSS and the corresponding snapshot.
Noticed that this part was not used while editing tests, so got rid of it. #boyscoutrule
thecrypticace
approved these changes
Nov 6, 2024
|
We were a bit too fast on this one. As the original PR points out: #14095 This is a needed feature in some cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
theme(inline)option for now. We might re-introduce this in the future but for now we get rid of it to ensure there are fewer knobs to turn.We still have the
inlineoption internally because it is used in the v3 compat layer.