Migrate [&>*] to * variant, and [&_*] to ** variant
#15022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
feat/migrate-to-child-variant
branch
from
ca56186 to
d7ef64f
Compare
RobinMalfait
changed the title
[&>*] to * variant[&>*] to * variant, and [&_*] to ** variant
RobinMalfait
force-pushed
the
feat/migrate-to-child-variant
branch
from
3a1858f to
fe2981a
Compare
RobinMalfait
force-pushed
the
feat/migrate-to-child-variant
branch
from
fe2981a to
d86f06e
Compare
thecrypticace
approved these changes
Nov 18, 2024
RobinMalfait
commented
Nov 18, 2024
adamwathan
reviewed
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a migration to convert the
[&>*]variant to the*variant. Additionally this PR also converts the[&_*]variant to the**variant.We use this variant in Catalyst for example, and now that the specificity is the same as
*, we can use the more modern syntax instead.Test plan:
Running this on Catalyst results in a diff like:
Note: the swapped order of variants is another codemod at work