Fix order-first and order-last for Firefox
#16266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `calc(infinity)` is supposed to work in Firefox, and it does in
places like `rounded-full` which generate:
```css
.rounded-full {
border-radius: calc(infinity * 1px);
}
```
But in places for `order`, it doesn't complain and is valid, yet it just
doesn't work.
philipp-spiess
approved these changes
Feb 5, 2025
|
We should probably file a browser bug for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
order-lastdoesn't work as expected in Firefox.The implementation of
order-last, looks like this:Which is valid CSS, and
calc(infinity)is even valid in Firefox. You can use this in other properties such asborder-radius:While this works, in properties like
orderit just doesn't work.Fixes: #16165