-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failing test for #2823 #2824
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2824 +/- ##
==========================================
+ Coverage 93.20% 93.22% +0.01%
==========================================
Files 177 177
Lines 1795 1800 +5
Branches 317 318 +1
==========================================
+ Hits 1673 1678 +5
Misses 105 105
Partials 17 17
Continue to review full report at Codecov.
|
Hey! Thank you for your PR! I love that you pushed a failing test! I pushed the fixes directly to your branch. Thanks! |
The pleasure's mine - thanks for a great library! |
Here's a failing test for #2823.
Fixes: #2823