[WIP] Unify JIT and AOT code paths #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
cleanup-codepaths
branch
from
dd88b1c to
581e0a0
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4188 +/- ##
===========================================
- Coverage 86.84% 70.08% -16.77%
===========================================
Files 341 219 -122
Lines 4836 5456 +620
Branches 919 1032 +113
===========================================
- Hits 4200 3824 -376
- Misses 561 1469 +908
- Partials 75 163 +88 ☔ View full report in Codecov by Sentry. |
Still lots of clean up that can be done in some of the more complex ones, but at least it's one file per plugin now.
adamwathan
force-pushed
the
cleanup-codepaths
branch
from
63522aa to
33df925
Compare
adamwathan
added a commit
that referenced
this pull request
May 7, 2021
* WIP * WIP * Finish combining JIT and AOT plugins Still lots of clean up that can be done in some of the more complex ones, but at least it's one file per plugin now. * Remove unused import * Fix AOT generation bugs * Move corePlugins/index.js to corePlugins.js * Convert JIT files to ESM * Move tests * Reorder core plugins to match JIT order * Update AOT apply tests * Unify utils * Combine plugin lists to one single source of truth * Finish resolving merge conflicts, fix tests Co-authored-by: Adam Wathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP start by unifying JIT and AOT codepaths.