[roborazzi-idea-plugin] Fix: Icons are not shown in the new UI #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirom
force-pushed
the
takahirom/fix-icons-are-not-shown-for-new-ui/2024-07-03
branch
from
1ed4d3a to
5d16c3c
Compare
takahirom
changed the title
takahirom
changed the title
takahirom
deleted the
takahirom/fix-icons-are-not-shown-for-new-ui/2024-07-03
branch
chrisbanes
referenced
this pull request
in chrisbanes/haze
Jul 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | `1.21.0` -> `1.22.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | `1.21.0` -> `1.22.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi-compose-desktop](https://togithub.com/takahirom/roborazzi) | `1.21.0` -> `1.22.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | `1.21.0` -> `1.22.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | `1.21.0` -> `1.22.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.22.1`](https://togithub.com/takahirom/roborazzi/releases/tag/1.22.1) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.22.0...1.22.1) ### Bug fixes We've released Experimental Compose Preview Support in [1.22.0](https://togithub.com/takahirom/roborazzi/releases/tag/1.22.0). In this release, we are going to include a bug fix for it. The strategy of `generateComposePreviewRobolectricTests{}` is not to modify settings automatically, but to verify that the user settings are correct. This allows our settings to be the single source of truth. However, the assertion had some bugs, so I fixed them. #### What's Changed - \[Roborazzi Idea Plugin] Generate Roborazzi images via its IntelliJ Plugin by [@​eyedol](https://togithub.com/eyedol) in [https://github.com/takahirom/roborazzi/pull/429](https://togithub.com/takahirom/roborazzi/pull/429) (We will address this topic in a future release) - \[Bug fixes] Fix assertions in Automated Test Generation for Experimental Compose Preview Support by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/432](https://togithub.com/takahirom/roborazzi/pull/432) **Full Changelog**: takahirom/roborazzi@1.22.0...1.22.1 ### [`v1.22.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.22.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.21.0...1.22.0) ### Experimental Compose Preview Support 🚀 We're excited to announce the experimental release of [Compose Preview Support for Roborazzi](https://takahirom.github.io/roborazzi/preview-support.html), a powerful new feature that streamlines the process of generating screenshot tests for Jetpack Compose Previews. #### Key Features - **Automated Test Generation**: Automatically generate screenshot tests for Composable Previews using the [ComposablePreviewScanner](https://togithub.com/sergio-sastre/ComposablePreviewScanner) library - **Manual Integration Support**: For those who prefer more control, we've added helper functions to manually integrate Compose Preview screenshot tests. #### How to Use To enable Compose Preview screenshot test generation, add the following to your `build.gradle.kts`: ```kotlin roborazzi { generateComposePreviewRobolectricTests { enable = true } } ``` After configuration, run the `recordRoborazziDebug` task to generate screenshots using the newly created tests. #### Customization Options Customize your setup with options like: - Specifying package names to scan - Defining a custom test class - Configuring Robolectric settings #### Manual Integration For manual integration, add the following dependency: ```kotlin testImplementation("io.github.takahirom.roborazzi:roborazzi-compose-preview-scanner-support:[version]") ``` Then use the `ComposablePreview<AndroidPreviewInfo>.captureRoboImage()` function in your tests. Note that `ComposablePreview` is a class provided by the [ComposablePreviewScanner](https://togithub.com/sergio-sastre/ComposablePreviewScanner) library, which Roborazzi utilizes for this feature. This approach allows for more fine-grained control over the screenshot capture process for Compose Previews. #### Acknowledgements Special thanks to [@​yschimke](https://togithub.com/yschimke) for the initial proposal, and to [@​sergio-sastre](https://togithub.com/sergio-sastre) and [@​yschimke](https://togithub.com/yschimke) for their valuable design and code reviews. For more detailed information on setup and usage, please visit our [documentation](https://takahirom.github.io/roborazzi/preview-support.html). ### Enhanced Accessibility Text Capture Thanks to [@​lukas-mercari](https://togithub.com/lukas-mercari) 's contribution, we've improved accessibility text dumping for merged Compose elements. Both content descriptions and text are now captured, providing more comprehensive accessibility information in tests.  #### What's Changed - \[roborazzi-idea-plugin] Fix: Icons are not shown in the new UI by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/421](https://togithub.com/takahirom/roborazzi/pull/421) - \[CI]Wait for main to succeed for compare ci by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/422](https://togithub.com/takahirom/roborazzi/pull/422) - \[CI] Remove main push trigger from compare ci by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/423](https://togithub.com/takahirom/roborazzi/pull/423) - \[CI] Add unit test for WebAssets class by [@​eyedol](https://togithub.com/eyedol) in [https://github.com/takahirom/roborazzi/pull/412](https://togithub.com/takahirom/roborazzi/pull/412) - \[Sample]Update dependency androidx.compose.foundation:foundation to v1.6.8 by [@​renovate](https://togithub.com/renovate) in [https://github.com/takahirom/roborazzi/pull/340](https://togithub.com/takahirom/roborazzi/pull/340) - \[Bug fixes] Dump both content description as well as text for the case when two elements are merged by [@​lukas-mercari](https://togithub.com/lukas-mercari) in [https://github.com/takahirom/roborazzi/pull/430](https://togithub.com/takahirom/roborazzi/pull/430) - \[Improvement] Add roborazzi-compose-preview-scanner-support module to handle preview settings by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/427](https://togithub.com/takahirom/roborazzi/pull/427) - \[Feature] Implement generateRobolectricPreviewTests prototype by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/416](https://togithub.com/takahirom/roborazzi/pull/416) **Full Changelog**: takahirom/roborazzi@1.21.0...1.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chrisbanes/haze). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot
referenced
this pull request
in slackhq/circuit
Jul 17, 2024
](https://renovatebot.com){kind=link}
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | plugin | minor | `1.21.0` -> `1.22.2` | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.21.0` -> `1.22.2` | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.21.0` -> `1.22.2` | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.21.0` -> `1.22.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.22.2`](https://togithub.com/takahirom/roborazzi/releases/tag/1.22.2) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.22.1...1.22.2) ##### Notice [RobolectricPreviewTest and roborazzi.generateComposePreviewRobolectricTests.customTestQualifiedClassName](https://takahirom.github.io/roborazzi/preview-support.html#customizing-the-preview-screenshot-test) are used for customizing [Experimental Compose Preview Support](https://takahirom.github.io/roborazzi/preview-support.html). However, the name and class signature of RobolectricPreviewTest will be changed in a future release(not in 1.22.2) to support the Compose Multiplatform Preview Annotation. ##### Bug fixes We didn't have integration tests for [Experimental Compose Preview Support](https://takahirom.github.io/roborazzi/preview-support.html), so we added them. In KMP projects, we used to check only `testImplementation` (androidUnitTest.dependencies.implementation is used for KMP Android Unit tests), and the verification for generateComposePreviewRobolectricTests{} was failing. Therefore, we have added integration tests and fixed the behavior for KMP projects. ##### What's Changed - Refactor Roborazzi integration tests to support multiple modules by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/434](https://togithub.com/takahirom/roborazzi/pull/434) - Fix warning of RoborazziPreviewParameterizedTests by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/436](https://togithub.com/takahirom/roborazzi/pull/436) - Fix GenerateRobolectricComposePreviewTests to support KMP by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/435](https://togithub.com/takahirom/roborazzi/pull/435) **Full Changelog**: takahirom/roborazzi@1.22.1...1.22.2 ### [`v1.22.1`](https://togithub.com/takahirom/roborazzi/releases/tag/1.22.1) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.22.0...1.22.1) ##### Bug fixes We've released Experimental Compose Preview Support in [1.22.0](https://togithub.com/takahirom/roborazzi/releases/tag/1.22.0). In this release, we are going to include a bug fix for it. The strategy of `generateComposePreviewRobolectricTests{}` is not to modify settings automatically, but to verify that the user settings are correct. This allows our settings to be the single source of truth. However, the assertion had some bugs, so I fixed them. ##### What's Changed - \[Roborazzi Idea Plugin] Generate Roborazzi images via its IntelliJ Plugin by [@​eyedol](https://togithub.com/eyedol) in [https://github.com/takahirom/roborazzi/pull/429](https://togithub.com/takahirom/roborazzi/pull/429) (We will address this topic in a future release) - \[Bug fixes] Fix assertions in Automated Test Generation for Experimental Compose Preview Support by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/432](https://togithub.com/takahirom/roborazzi/pull/432) **Full Changelog**: takahirom/roborazzi@1.22.0...1.22.1 ### [`v1.22.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.22.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.21.0...1.22.0) ##### Experimental Compose Preview Support 🚀 We're excited to announce the experimental release of [Compose Preview Support for Roborazzi](https://takahirom.github.io/roborazzi/preview-support.html), a powerful new feature that streamlines the process of generating screenshot tests for Jetpack Compose Previews. ##### Key Features - **Automated Test Generation**: Automatically generate screenshot tests for Composable Previews using the [ComposablePreviewScanner](https://togithub.com/sergio-sastre/ComposablePreviewScanner) library - **Manual Integration Support**: For those who prefer more control, we've added helper functions to manually integrate Compose Preview screenshot tests. ##### How to Use To enable Compose Preview screenshot test generation, add the following to your `build.gradle.kts`: ```kotlin roborazzi { generateComposePreviewRobolectricTests { enable = true } } ``` After configuration, run the `recordRoborazziDebug` task to generate screenshots using the newly created tests. ##### Customization Options Customize your setup with options like: - Specifying package names to scan - Defining a custom test class - Configuring Robolectric settings ##### Manual Integration For manual integration, add the following dependency: ```kotlin testImplementation("io.github.takahirom.roborazzi:roborazzi-compose-preview-scanner-support:[version]") ``` Then use the `ComposablePreview<AndroidPreviewInfo>.captureRoboImage()` function in your tests. Note that `ComposablePreview` is a class provided by the [ComposablePreviewScanner](https://togithub.com/sergio-sastre/ComposablePreviewScanner) library, which Roborazzi utilizes for this feature. This approach allows for more fine-grained control over the screenshot capture process for Compose Previews. ##### Acknowledgements Special thanks to [@​yschimke](https://togithub.com/yschimke) for the initial proposal, and to [@​sergio-sastre](https://togithub.com/sergio-sastre) and [@​yschimke](https://togithub.com/yschimke) for their valuable design and code reviews. For more detailed information on setup and usage, please visit our [documentation](https://takahirom.github.io/roborazzi/preview-support.html). ##### Enhanced Accessibility Text Capture Thanks to [@​lukas-mercari](https://togithub.com/lukas-mercari) 's contribution, we've improved accessibility text dumping for merged Compose elements. Both content descriptions and text are now captured, providing more comprehensive accessibility information in tests.  ##### What's Changed - \[roborazzi-idea-plugin] Fix: Icons are not shown in the new UI by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/421](https://togithub.com/takahirom/roborazzi/pull/421) - \[CI]Wait for main to succeed for compare ci by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/422](https://togithub.com/takahirom/roborazzi/pull/422) - \[CI] Remove main push trigger from compare ci by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/423](https://togithub.com/takahirom/roborazzi/pull/423) - \[CI] Add unit test for WebAssets class by [@​eyedol](https://togithub.com/eyedol) in [https://github.com/takahirom/roborazzi/pull/412](https://togithub.com/takahirom/roborazzi/pull/412) - \[Sample]Update dependency androidx.compose.foundation:foundation to v1.6.8 by [@​renovate](https://togithub.com/renovate) in [https://github.com/takahirom/roborazzi/pull/340](https://togithub.com/takahirom/roborazzi/pull/340) - \[Bug fixes] Dump both content description as well as text for the case when two elements are merged by [@​lukas-mercari](https://togithub.com/lukas-mercari) in [https://github.com/takahirom/roborazzi/pull/430](https://togithub.com/takahirom/roborazzi/pull/430) - \[Improvement] Add roborazzi-compose-preview-scanner-support module to handle preview settings by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/427](https://togithub.com/takahirom/roborazzi/pull/427) - \[Feature] Implement generateRobolectricPreviewTests prototype by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/416](https://togithub.com/takahirom/roborazzi/pull/416) **Full Changelog**: takahirom/roborazzi@1.21.0...1.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #420