Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warnings when Accessibility checks not configured correctly #572

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

yschimke
Copy link
Contributor

@yschimke yschimke commented Nov 23, 2024

Add tests showing we don't fail when configured incorrectly, and log if not in NATIVE mode.

relates to #569

@yschimke yschimke changed the title Log warnings when not configured correctly Log warnings when Accessibility checks not configured correctly Nov 23, 2024
Copy link
Owner

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your contribution!

@takahirom takahirom merged commit cb73af6 into takahirom:main Nov 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants