Apply suppressions to AccessibilityViewCheckResult instead of filtering #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new `applySuppressions` function to process suppressions for accessibility check results. It filters results based on suppression rules and adds a new `AccessibilityCheckResultType.SUPPRESSED` type for suppressed results. Additionally, it adds logging for suppressed results.
takahirom
reviewed
Nov 23, 2024
| AccessibilityCheckResultType.INFO | ||
| ) | ||
|
|
||
| return map { checkResult -> |
There was a problem hiding this comment.
I'm a little confused, so I added the parameter name. 👀
yschimke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new
applySuppressionsfunction to process suppressions for accessibility check results. It filters results based on suppression rules and adds a newAccessibilityCheckResultType.SUPPRESSEDtype for suppressed results. Additionally, it adds logging for suppressed results.Existing logic filters instead of suppressing, making these invisible.
fixes #570