Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for HTML result will break when context data key has special char… #654

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

unni-dm
Copy link
Contributor

@unni-dm unni-dm commented Feb 12, 2025

When you have special characters in context data (like space), the final result html file will break.

Uncaught SyntaxError: Failed to execute 'querySelectorAll' on 'Document': '#Galaxy%20S22%20Ultra' is not a valid selector.

Fix is to remove special characters from id.

Before After
Screenshot 2025-02-12 at 13 55 30 Screenshot 2025-02-12 at 13 52 36
Screenshot 2025-02-12 at 13 55 45

@takahirom
Copy link
Owner

Thanks. I'll merge this and release as 1.41.1

@takahirom takahirom merged commit a8d1d20 into takahirom:main Feb 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants