Merge pull request #197 from takenet/feature/610355-remove-status-cha…

…nge-to-start-input-expiration Removing status change for start block when input expiration limit has been exceeded
takenet · Mar 13, 2024 · ddd7df5 · ddd7df5
2 parents dc693ae + 20347b0
commit ddd7df5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/src/Take.Blip.Builder.UnitTests/InputExpirationHandlerTests.cs b/src/Take.Blip.Builder.UnitTests/InputExpirationHandlerTests.cs
@@ -30,7 +30,6 @@ public class InputExpirationHandlerTests
         private readonly ILogger Logger;
         private readonly IInputExpirationCount _inputExpirationCount;
         private readonly IConfiguration _configuration;
-        private readonly IStateManager _stateManager;
 
         public InputExpirationHandlerTests()
         {
@@ -51,8 +50,7 @@ public InputExpirationHandlerTests()
             Logger = Substitute.For<ILogger>();
             _inputExpirationCount = Substitute.For<IInputExpirationCount>();
             _configuration = Substitute.For<IConfiguration>();
-            _stateManager = Substitute.For<IStateManager>();
-            InputHandler = new InputExpirationHandler(Scheduler, Logger, _inputExpirationCount, _stateManager, _configuration);
+            InputHandler = new InputExpirationHandler(Scheduler, Logger, _inputExpirationCount, _configuration);
         }
 
         [Fact]
@@ -216,7 +214,6 @@ await Scheduler
                      Arg.Any<DateTimeOffset>(),
                      Arg.Any<Node>(),
                      Arg.Is<CancellationToken>(c => !c.IsCancellationRequested));
-            await _stateManager.Received(1).ResetUserState(null, default(CancellationToken));
             await _inputExpirationCount.Received(1).TryRemoveAsync(Message);
         }
 

diff --git a/src/Take.Blip.Builder/InputExpirationHandler.cs b/src/Take.Blip.Builder/InputExpirationHandler.cs
@@ -8,8 +8,6 @@
 using Take.Blip.Builder.Diagnostics;
 using Take.Blip.Builder.Hosting;
 using Take.Blip.Builder.Models;
-using Take.Blip.Builder.Storage;
-using Take.Blip.Client;
 using Take.Blip.Client.Content;
 using Take.Blip.Client.Extensions.Scheduler;
 using Takenet.Iris.Messaging.Resources;
@@ -31,20 +29,17 @@ public class InputExpirationHandler : IInputMessageHandler
         private readonly ILogger _logger;
         private readonly IInputExpirationCount _inputExpirationCount;
         private readonly IConfiguration _configuration;
-        private readonly IStateManager _stateManager;
 
         /// <summary>
         /// Constructor
         /// </summary>
         /// <param name="schedulerExtension"></param>
-        public InputExpirationHandler(ISchedulerExtension schedulerExtension, ILogger logger, IInputExpirationCount inputExpirationCount, IStateManager stateManager, IConfiguration configuration)
+        public InputExpirationHandler(ISchedulerExtension schedulerExtension, ILogger logger, IInputExpirationCount inputExpirationCount, IConfiguration configuration)
         {
             _schedulerExtension = schedulerExtension;
             _logger = logger;
             _inputExpirationCount = inputExpirationCount;
             _configuration = configuration;
-            _stateManager = stateManager;
-
         }
 
         /// <summary>
@@ -220,7 +215,6 @@ private async Task<bool> ValidateInputExirationCountAsync(State state, Message m
                 var inputExpirationCount = await _inputExpirationCount.IncrementAsync(message);
                 if (inputExpirationCount > _configuration.MaximumInputExpirationLoop)
                 {
-                    await _stateManager.ResetUserState(context, cancellationToken);
                     await _inputExpirationCount.TryRemoveAsync(message);
                     _logger.Warning("[{Source}] [FlowConstruction] Max input expiration transitions of {MaximumInputExpirationLoop} was reached",
                      nameof(InputExpirationHandler), _configuration.MaximumInputExpirationLoop);