Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gRPC keepalive server parameters #52

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

FerroEduardo
Copy link
Contributor

Reason

Due to the nature of HTTP/2 of keeping persistent connections, the usage of the default gRPC Keepalive parameters may become a problem when dealing with k8s autoscaling. The possibility of setting up MAX_CONNECTION_AGE server parameter also enables others client capabilities, such as gRPC client load balancing (1, 2) (without service mesh, such as Istio).

Description

This PR proposes the addition of configurable gRPC server Keepalive parameters.

As the environment variables and keepalive.ServerParameters struct fields are optional, Deckard's previous behavior will remain the same.

References

Copy link
Member

@lucasoares lucasoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test failure, fix it and then lgtm

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (5a2182c) to head (e382b6e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   82.11%   82.21%   +0.09%     
==========================================
  Files          26       26              
  Lines        3696     3716      +20     
==========================================
+ Hits         3035     3055      +20     
  Misses        519      519              
  Partials      142      142              
Files with missing lines Coverage Δ
internal/service/deckard_service.go 80.03% <100.00%> (+0.76%) ⬆️

@lucasoares lucasoares merged commit f74fb3f into takenet:main Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants