Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring4 #31

Merged
merged 2 commits into from
Dec 13, 2013
Merged

Spring4 #31

merged 2 commits into from
Dec 13, 2013

Conversation

davidkarlsen
Copy link
Contributor

This fixes #27 with the upgrade to the spring 4.0.0.Final version available as of today.

Could you pull this and make a release? Maybe you want to bump the x or y version in x.y.z due to this?

@slandelle
Copy link
Contributor

Hi,

Actually, judging from your commits, it looks like supporting Spring 4 is just a matter of changing the dependency and there's no impact on the code.

If you want to use spring-dbunit w/ Spring 4, why don't you simply use something like maven's dependencyManagement?
At this point, I don't see a reason force enforcing Spring 4 that's just been released to all users.

Cheers,

Stéphane

@davidkarlsen
Copy link
Contributor Author

If you look at the issue-descriptions in
#27 and
https://jira.springsource.org/browse/SPR-7692 you will see that TestContext
is no longer a class but an interface in Spring 4, and thus you will
get a IncompatibleClassChangeError
if you simply set spring 4 in the dependency section. By not compiling
towards spring 4 you are leaving users with no option to upgrade spring and
use spring-dbunit at the same time...

@slandelle
Copy link
Contributor

OK, so let's bump version then.

slandelle pushed a commit that referenced this pull request Dec 13, 2013
@slandelle slandelle merged commit 35bc605 into takimafr:master Dec 13, 2013
@davidkarlsen davidkarlsen deleted the spring4 branch December 13, 2013 15:21
@davidkarlsen
Copy link
Contributor Author

Great! Will you push a release as well?

@slandelle
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible classchange error with spring 4.x
2 participants