Implement console command section property
#179
Conversation
bastimeyer
force-pushed
the
feature/commands-console
branch
from
0a5a7e8 to
a626d3a
Compare
|
Just built a couple of installers and noticed a quotation mistake in NSIS' _assemble_launchers call. That's fixed now. |
|
@takluyver Is there a chance for a review this week? I would really love to get this issue out of the way as soon as possible. Thanks! |
|
Sorry for the delay; as I hinted, this isn't part of my day job, and I don't always feel like more work with code after spending the day doing that. Taking a look now. |
|
|
||
| If ``true`` (default), the command will be using the ``py`` launcher, which | ||
| opens a console for the process. If ``false``, it will use the ``pyw`` | ||
| launcher, which doesn't create a console. |
There was a problem hiding this comment.
I guess this was copy/pasted, but we don't actually use the py or pyw launchers any more. They were to do with the way Pynsist 1.x worked. I can change this afterwards, though.
There was a problem hiding this comment.
Yes, this was copied from the shortcut section. I'll leave it for you to change afterwards. 😃
bastimeyer
force-pushed
the
feature/commands-console
branch
from
a626d3a to
070f1c4
Compare
bastimeyer
force-pushed
the
feature/commands-console
branch
from
070f1c4 to
91f39ef
Compare
|
Any further changes, or is this good to go? :) |
|
Thanks! 😃 |
As described in #169
Adds an optional
consoleproperty to the command sections with default valuetrue. If set tofalse, the command's launcher will be built from one of the GUI launchers ofsimple_launcherand a shebang withpythonw.exewill be included instead ofpython.exe.Changes:
consolecommand propertylauncher_exe.datandlauncher_noconsole_exe.dat)command-append.zipandcommand-append-noconsole.zip, depending on the command'sconsolevalue_assemble_launchers.pyto reflect these changes and change its argvs so that the shebang can be testedI haven't actually built any installers with these changes yet, but the updated tests should assure that this is fine. There are also a couple of things which could be improved in the future, like importing file name constants for example.