Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slap-reproject to setup cfg #48

Merged
merged 3 commits into from
Jun 15, 2024
Merged

add slap-reproject to setup cfg #48

merged 3 commits into from
Jun 15, 2024

Conversation

ericleonardis
Copy link
Contributor

Running 'slap-reproject' resulted in an error where 'slap-reproject is not recognized as an internal or external command' which was identified in issue #46. This was because the reproject_cli was not added to the setup.cfg file in the console_scripts entry points. I have added slap-reproject to that list and the file is now being created as expected.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.49%. Comparing base (c8f952e) to head (b8d8df2).

Current head b8d8df2 differs from pull request most recent head 44aace6

Please upload reports for the commit 44aace6 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files           3        3           
  Lines         298      298           
=======================================
  Hits          222      222           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sean-afshar sean-afshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be sleap_anipose:triangulation.reproject_cli instead of sleap_anipose.triangulate:reproject_cli?

@ericleonardis
Copy link
Contributor Author

Should it not be sleap_anipose:triangulation.reproject_cli instead of sleap_anipose.triangulate:reproject_cli?

whoops, sorry! very confused as to why it still generated the reprojections despite that error... but I fixed it now and it runs!

Copy link
Contributor

@sean-afshar sean-afshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sean-afshar sean-afshar merged commit 0cac28a into main Jun 15, 2024
1 of 2 checks passed
@sean-afshar sean-afshar deleted the eric/reproj-cli branch June 15, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants