Reroute Video
cattr to Video.from_filename
#1327
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lately, we have been experiencing an intermittent failure revolving around restructuring
Video
s. Namely, we have seen thatSingleImageVideo
s will occasionally be routed to theNumpyVideo
backend when restructuring viacattr
. This PR reroutes the cattrVideo
restructuring toVideo.from_filename
(which is the default method when addingVideo
s to the GUI).Update
Using
Video.from_filename
when restructuring leads to some strange behavior inLabels.copy
. Namely, what if we want to load in a labels object even if the video filename cannot be found - just to access other attributes in theLabels
object? Unless we handle this loading using aLabels.make_video_search
first, then we cannot load theLabels
without being able to locate the video file. So, back to the drawing board: see #1330.Past attempted fix: #1267
Test failure
Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️