-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Temp MV fix to] add frame to Instance (when using Labels.add_instance) #2011
[Temp MV fix to] add frame to Instance (when using Labels.add_instance) #2011
Conversation
This is more permanently fixed by the InstancesList class added in #1807
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## liezl/add-gui-elements-for-sessions #2011 +/- ##
====================================================================
Coverage 74.18% 74.18%
====================================================================
Files 135 135
Lines 25440 25441 +1
====================================================================
+ Hits 18873 18874 +1
Misses 6567 6567 ☔ View full report in Codecov by Sentry. |
62035aa
into
liezl/add-gui-elements-for-sessions
Description
A multiview branch beta tester has reported that they are unable to add an
Instance
to anInstanceGroup
. This occurred when copying and pasting theInstance
from a previousLabeledFrame
. Upon investigation, we found the following error message(thank you previous dev/self for adding checks and error messages - otherwise this may have turned into quite the chase).
InstancesList
class that replaces the nativelist
implementation forLabels._instance
and ensures that theLabeledFrame
is updated when anInstance
is moved around, deleted, etc. Thus, this fix is temporary and should not be merged into develop. See #1807 for more details.Types of changes
Does this address any currently open issues?
InstancesList
class to handle backref toLabeledFrame
#1807Outside contributors checklist
Thank you for contributing to SLEAP!
❤️