Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to set grayscale when replacing videos (mp4/avi only) #787
Allow user to set grayscale when replacing videos (mp4/avi only) #787
Changes from all commits
785cb67
76958e0
063e604
0aba7b4
b592115
1e7af46
3c0d8bf
b720cc9
4e97d95
9f618be
151d5f5
fe4f564
4259be8
3f33788
25785bb
e7e9a8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is triggered even when labels are not added/changed (but another "change" was registered). Is there a way to check that just the labels object has changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be amazing -- I've looked into it in the past but it doesn't seem trivial. Search for
"has_changes"
across the codebase.In general, it's just a tricky pattern to implement. Here's some relevant literature: https://refactoring.guru/design-patterns/state