fix: Price which is set to 0 for CartItem / AdditionalCost are now sent correctly and not ignored
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altJake
added a commit
that referenced
this pull request
Mar 27, 2022
### Problem Open API Generator sets `DataMember` attribute's `EmitDefaultValue` per default to `false`. Unfortunately for some of our data models, it means that the emitted JSON for decimal values of `0` are ignored. ### Solution Manually override the setting for those fields in these models. Currently supported: - `src/TalonOne/Model/CartItem.cs`'s `Position` property - `src/TalonOne/Model/ReturnedCartItem.cs`'s `Position` property - `src/TalonOne/Model/SetDiscountPerItemEffectProps.cs`'s `Position` property ### Notes - This is a similar problem to the one fixed in #19 , with a couple of new Models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Open API Generator sets
DataMemberattribute'sEmitDefaultValueper default tofalse.Unfortunately for some of our data models, it means that the emitted JSON for decimal values of
0are ignored.Solution
There's no nice way to address the problem gracefully using a configuration value for the Open API Generator, so currently we manually override the setting for those models.
Currently supported:
CartItem'sPricepropertyAdditionalCost'sPriceproperty